Thread (18 messages) 18 messages, 6 authors, 2025-02-06

Re: [PATCH v8 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions

From: Manikanta Mylavarapu <hidden>
Date: 2024-10-28 07:46:25
Also in: linux-arm-kernel, linux-arm-msm, linux-clk, linux-devicetree, lkml


On 10/25/2024 5:30 PM, Krzysztof Kozlowski wrote:
On Fri, Oct 25, 2024 at 09:25:17AM +0530, Manikanta Mylavarapu wrote:
quoted
From: Devi Priya <redacted>

Add NSSCC clock and reset definitions for ipq9574.

Signed-off-by: Devi Priya <redacted>
Signed-off-by: Manikanta Mylavarapu <redacted>
---
Changes in V8:
	- Replace bias_pll_cc_clk, bias_pll_ubi_nc_clk with CMN_PLL
	  NSS_1200MHZ_CLK and PPE_353MHZ_CLK
	- Remove bias_pll_nss_noc_clk because it's not required.
	- Drop R-b tag
That's not really a change waranting re-review.

I wished you did not create here dependency, skipped the header and just
use some number for the clock. Having dependencies does not help anyone:
neither you to get this merged, nor us to see that it was tested.

Please confirm that this patch was fully tested.

Reviewed-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof
Yes, it's fully tested.

Thanks & Regards,
Manikanta.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help