Re: [PATCH net-next v3 05/10] net: ip: make ip_route_input_slow() return drop reasons
From: Paolo Abeni <pabeni@redhat.com>
Date: 2024-10-21 10:52:55
Also in:
bpf, bridge, lkml, netfilter-devel
On 10/15/24 16:07, Menglong Dong wrote:
quoted hunk ↗ jump to hunk
@@ -2316,19 +2327,25 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr, err = -EHOSTUNREACH; goto no_route; } - if (res->type != RTN_UNICAST) + if (res->type != RTN_UNICAST) { + reason = SKB_DROP_REASON_IP_INVALID_DEST; goto martian_destination; + } make_route: err = ip_mkroute_input(skb, res, in_dev, daddr, saddr, dscp, flkeys); -out: return err; + if (!err) + reason = SKB_NOT_DROPPED_YET; + +out: return reason;
Since you are touching this line, please rewrite the code with a more natural indentation: out: return reason; Thanks, Paolo