RE: [PATCH net v2 0/4] net: stmmac: dwmac4: Fixes bugs in dwmac4

-----Original Message-----
From: Simon Horman <horms@kernel.org>
Sent: Thursday, October 17, 2024 10:10 PM
To: Leyfoon Tan <redacted>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>; Jose Abreu
[off-list ref]; David S . Miller [off-list ref]; Eric
Dumazet [off-list ref]; Jakub Kicinski [off-list ref]; Paolo
Abeni [off-list ref]; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org; lftan.linux@gmai.com
Subject: Re: [PATCH net v2 0/4] net: stmmac: dwmac4: Fixes bugs in dwmac4

On Wed, Oct 16, 2024 at 11:18:28AM +0800, Ley Foon Tan wrote:

quoted

This patch series fix the bugs in dwmac4 drivers.

Changes since v1:
- Removed empty line between Fixes and Signoff
- Rebased to
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
- Updated git commit description for patch 4/4

History:
v1:
https://patchwork.kernel.org/project/netdevbpf/cover/20241015065708.34
65151-1-leyfoon.tan@starfivetech.com/

Hi,

Thanks for the update and sorry for not providing more timely feedback.

I think that the code changes themselves look fine. However, as a rule of
thumb, fixes for net should resolve user-visible problems.
I see that is the case for patch 4/4, but it is less clear to me for the other 3
patches. If it is indeed then I think it would be good to explain that more
clearly in their patch descriptions.

If not, perhaps they should be submitted to net-next without Fixes tags while
patch 4 and any others that are still fixes resubmitted as a smaller
v3 patch-set for net.

...

Patch 1-3 no user-visible problem so far.
Patch 1-3 will submit to net-next, and Patch 4 will submit to net.

Regards
Ley Foon