Re: [PATCH net-next v3 3/9] Bluetooth: RFCOMM: avoid leaving dangling sk pointer in rfcomm_sock_alloc()

On Mon, Oct 14, 2024 at 11:30 PM Kuniyuki Iwashima [off-list ref] wrote:

From: Ignat Korchagin <redacted>
Date: Mon, 14 Oct 2024 16:38:02 +0100

quoted

bt_sock_alloc() attaches allocated sk object to the provided sock object.
If rfcomm_dlc_alloc() fails, we release the sk object, but leave the
dangling pointer in the sock object, which may cause use-after-free.

Fix this by swapping calls to bt_sock_alloc() and rfcomm_dlc_alloc().

Signed-off-by: Ignat Korchagin <redacted>

Reviewed-by: Kuniyuki Iwashima <redacted>

Reviewed-by: Eric Dumazet <redacted>