Re: [PATCH net-next v7 08/12] net: vxlan: use kfree_skb_reason() in vxlan_xmit()
From: Ido Schimmel <idosch@nvidia.com>
Date: 2024-10-14 15:47:52
Also in:
lkml
On Mon, Oct 14, 2024 at 08:35:57PM +0800, Menglong Dong wrote:
On Sun, Oct 13, 2024 at 8:43 PM Ido Schimmel [off-list ref] wrote:quoted
On Wed, Oct 09, 2024 at 10:28:26AM +0800, Menglong Dong wrote:quoted
Replace kfree_skb() with kfree_skb_reason() in vxlan_xmit(). Following new skb drop reasons are introduced for vxlan: /* no remote found for xmit */ SKB_DROP_REASON_VXLAN_NO_REMOTE /* packet without necessary metadata reached a device which is * in "external" mode */ SKB_DROP_REASON_TUNNEL_TXINFO Signed-off-by: Menglong Dong <redacted> Reviewed-by: Simon Horman <horms@kernel.org>Reviewed-by: Ido Schimmel <idosch@nvidia.com> The first reason might be useful for the bridge driver as well when there are no ports to forward the packet to (because of egress filtering for example), but we can make it more generic if / when the bridge driver is annotated.You are right. As we already need a new version, so we can do something for this patch too. As you said, maybe we can rename the reason VXLAN_NO_REMOTE to NO_REMOTE for more generic usage?
"NO_REMOTE" is not really applicable to the bridge driver as there are no remotes, but bridge ports. I'm fine with keeping it as is for now and changing it later if / when needed.