Re: [PATCH net-next v4 03/12] net: tunnel: add skb_vlan_inet_prepare_reason() helper

[PATCH net-next v4 00/12] net: vxlan: add skb drop reasons support · Menglong Dong <hidden> · 2024-10-01
[PATCH net-next v4 01/12] net: skb: add pskb_network_may_pull_reason() helper · Menglong Dong <hidden> · 2024-10-01
Re: [PATCH net-next v4 01/12] net: skb: add pskb_network_may_pull_reason() helper · Simon Horman <horms@kernel.org> · 2024-10-02
[PATCH net-next v4 02/12] net: tunnel: add pskb_inet_may_pull_reason() helper · Menglong Dong <hidden> · 2024-10-01
Re: [PATCH net-next v4 02/12] net: tunnel: add pskb_inet_may_pull_reason() helper · Simon Horman <horms@kernel.org> · 2024-10-02
Re: [PATCH net-next v4 02/12] net: tunnel: add pskb_inet_may_pull_reason() helper · Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com> · 2024-10-03
[PATCH net-next v4 03/12] net: tunnel: add skb_vlan_inet_prepare_reason() helper · Menglong Dong <hidden> · 2024-10-01
Re: [PATCH net-next v4 03/12] net: tunnel: add skb_vlan_inet_prepare_reason() helper · Simon Horman <horms@kernel.org> · 2024-10-02
Re: [PATCH net-next v4 03/12] net: tunnel: add skb_vlan_inet_prepare_reason() helper · Jakub Kicinski <kuba@kernel.org> · 2024-10-04
Re: [PATCH net-next v4 03/12] net: tunnel: add skb_vlan_inet_prepare_reason() helper · Menglong Dong <hidden> · 2024-10-06
[PATCH net-next v4 04/12] net: vxlan: add skb drop reasons to vxlan_rcv() · Menglong Dong <hidden> · 2024-10-01
Re: [PATCH net-next v4 04/12] net: vxlan: add skb drop reasons to vxlan_rcv() · Simon Horman <horms@kernel.org> · 2024-10-02
[PATCH net-next v4 05/12] net: vxlan: make vxlan_remcsum() return drop reasons · Menglong Dong <hidden> · 2024-10-01
Re: [PATCH net-next v4 05/12] net: vxlan: make vxlan_remcsum() return drop reasons · Simon Horman <horms@kernel.org> · 2024-10-02
Re: [PATCH net-next v4 05/12] net: vxlan: make vxlan_remcsum() return drop reasons · Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com> · 2024-10-03
[PATCH net-next v4 06/12] net: vxlan: make vxlan_snoop() return drop reasons · Menglong Dong <hidden> · 2024-10-01
Re: [PATCH net-next v4 06/12] net: vxlan: make vxlan_snoop() return drop reasons · Simon Horman <horms@kernel.org> · 2024-10-02
Re: [PATCH net-next v4 06/12] net: vxlan: make vxlan_snoop() return drop reasons · Menglong Dong <hidden> · 2024-10-03
[PATCH net-next v4 07/12] net: vxlan: make vxlan_set_mac() return drop reasons · Menglong Dong <hidden> · 2024-10-01
Re: [PATCH net-next v4 07/12] net: vxlan: make vxlan_set_mac() return drop reasons · Simon Horman <horms@kernel.org> · 2024-10-02
Re: [PATCH net-next v4 07/12] net: vxlan: make vxlan_set_mac() return drop reasons · Jakub Kicinski <kuba@kernel.org> · 2024-10-04
Re: [PATCH net-next v4 07/12] net: vxlan: make vxlan_set_mac() return drop reasons · Menglong Dong <hidden> · 2024-10-06
[PATCH net-next v4 08/12] net: vxlan: use kfree_skb_reason() in vxlan_xmit() · Menglong Dong <hidden> · 2024-10-01
Re: [PATCH net-next v4 08/12] net: vxlan: use kfree_skb_reason() in vxlan_xmit() · Simon Horman <horms@kernel.org> · 2024-10-02
Re: [PATCH net-next v4 08/12] net: vxlan: use kfree_skb_reason() in vxlan_xmit() · Jakub Kicinski <kuba@kernel.org> · 2024-10-04
Re: [PATCH net-next v4 08/12] net: vxlan: use kfree_skb_reason() in vxlan_xmit() · Menglong Dong <hidden> · 2024-10-06
[PATCH net-next v4 09/12] net: vxlan: add drop reasons support to vxlan_xmit_one() · Menglong Dong <hidden> · 2024-10-01
Re: [PATCH net-next v4 09/12] net: vxlan: add drop reasons support to vxlan_xmit_one() · Simon Horman <horms@kernel.org> · 2024-10-02
[PATCH net-next v4 10/12] net: vxlan: use kfree_skb_reason() in vxlan_mdb_xmit() · Menglong Dong <hidden> · 2024-10-01
Re: [PATCH net-next v4 10/12] net: vxlan: use kfree_skb_reason() in vxlan_mdb_xmit() · Simon Horman <horms@kernel.org> · 2024-10-02
[PATCH net-next v4 11/12] net: vxlan: use kfree_skb_reason() in vxlan_encap_bypass() · Menglong Dong <hidden> · 2024-10-01
Re: [PATCH net-next v4 11/12] net: vxlan: use kfree_skb_reason() in vxlan_encap_bypass() · Simon Horman <horms@kernel.org> · 2024-10-02
[PATCH net-next v4 12/12] net: vxlan: use kfree_skb_reason() in encap_bypass_if_local() · Menglong Dong <hidden> · 2024-10-01
Re: [PATCH net-next v4 12/12] net: vxlan: use kfree_skb_reason() in encap_bypass_if_local() · Simon Horman <horms@kernel.org> · 2024-10-02
Re: [PATCH net-next v4 12/12] net: vxlan: use kfree_skb_reason() in encap_bypass_if_local() · Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com> · 2024-10-03

From: Menglong Dong <hidden>
Date: 2024-10-06 03:51:48
Also in: lkml

On Sat, Oct 5, 2024 at 12:43 AM Jakub Kicinski [off-list ref] wrote:

On Tue,  1 Oct 2024 15:32:16 +0800 Menglong Dong wrote:

quoted

-static inline bool skb_vlan_inet_prepare(struct sk_buff *skb,
-                                      bool inner_proto_inherit)
+static inline enum skb_drop_reason
+skb_vlan_inet_prepare_reason(struct sk_buff *skb, bool inner_proto_inherit)

this only has 5 callers, please convert them to expect a drop
reason to be returned instead of adding a compatibility wrapper

Okay!

--
pw-bot: cr

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help