Re: [PATCH v7 1/6] misc: Add support for LAN966x PCI device
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2024-10-03 09:13:32
Also in:
linux-arm-kernel, linux-devicetree, linux-pci, lkml
Hi Hervé, On Thu, Oct 3, 2024 at 10:17 AM Herve Codina [off-list ref] wrote:
Add a PCI driver that handles the LAN966x PCI device using a device-tree overlay. This overlay is applied to the PCI device DT node and allows to describe components that are present in the device. The memory from the device-tree is remapped to the BAR memory thanks to "ranges" properties computed at runtime by the PCI core during the PCI enumeration. The PCI device itself acts as an interrupt controller and is used as the parent of the internal LAN966x interrupt controller to route the interrupts to the assigned PCI INTx interrupt. Signed-off-by: Herve Codina <herve.codina@bootlin.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thanks for your patch!
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/drivers/misc/lan966x_pci.dtso@@ -0,0 +1,167 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2022 Microchip UNG + */ + +#include <dt-bindings/clock/microchip,lan966x.h> +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/interrupt-controller/irq.h> +#include <dt-bindings/mfd/atmel-flexcom.h> +#include <dt-bindings/phy/phy-lan966x-serdes.h> + +/dts-v1/; +/plugin/; + +/ { + fragment@0 { + target-path="";
Nit: missing spaces around "=".
+ __overlay__ {
Unfortunately we cannot use sugar syntax, as sugar syntax does not
support empty target paths yet.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds