Thread (22 messages) 22 messages, 5 authors, 2024-10-02

Re: [PATCH v6 1/7] dt-bindings: reset: microchip,rst: Allow to replace cpu-syscon by an additional reg item

From: Herve Codina <herve.codina@bootlin.com>
Date: 2024-10-01 16:06:28
Also in: linux-arm-kernel, linux-devicetree, linux-pci, lkml

Hi Krystoff,

On Tue, 1 Oct 2024 08:43:23 +0200
Krzysztof Kozlowski [off-list ref] wrote:
On Mon, Sep 30, 2024 at 02:15:41PM +0200, Herve Codina wrote:
quoted
In the LAN966x PCI device use case, syscon cannot be used as syscon
devices do not support removal [1]. A syscon device is a core "system"
device and not a device available in some addon boards and so, it is not
supposed to be removed.  
That's not accurate. syscon is our own, Linux term which means also
anything exposing set of registers.

If you need to unload syscons, implement it. syscon is the same resource
as all others so should be handled same way.
quoted
In order to remove the syscon device usage, allow the reset controller
to have a direct access to the address range it needs to use.  
So you map same address twice? That's not good, because you have no
locking over concurrent register accesses.
I will remove this patch and keep using the syscon node in the next
iteration.

Best regards,
Hervé
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help