Thread (6 messages) 6 messages, 4 authors, 2024-10-02

Re: [RFC PATCH v2] Simply enable one to write code like:

From: Andy Shevchenko <hidden>
Date: 2024-10-01 15:09:06
Also in: lkml

On Tue, Oct 01, 2024 at 04:57:18PM +0200, Przemek Kitszel wrote:

...
NAKed-by: Andy Shevchenko [off-list ref]
And still NAKed.
Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
---
Andy believes that this change is completely wrong C, the reasons
(that I disagree with of course, are in v1, below the commit message).
Have you retested the macro expansion for this version?

...
  */
 
+
Too many blank lines.
+#define DEFINE_CLASS_IS_CONDITIONAL(_name, _is_cond)	\
+static __maybe_unused const bool class_##_name##_is_conditional = _is_cond
...
+	DEFINE_CLASS_IS_CONDITIONAL(_name, 0); \
Here and everywhere else, boolean has values true and false.

-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help