On Thu, Oct 3, 2024 at 10:26 AM Stanislav Fomichev [off-list ref] wrote:

On 10/03, Mina Almasry wrote:

quoted

On Mon, Sep 30, 2024 at 10:18 AM Stanislav Fomichev [off-list ref] wrote:

quoted

This is where all the tests that depend on the HW functionality live in
and this is where the automated test is gonna be added in the next
patch.

Tbh I don't like this very much. I wanted to take ncdevmem in the
opposite direction: to make at least the control path tests runnable
on netdevsim or something like that and have it not require any HW
support at all.

But I see in the cover letter that Jakub himself asked for the move,
so if there is some strong reason to make this in hw, sure.

Does it being under HW preclude future improvements to making it a
non-HW dependent test?

I'm moving it under drivers/net/hw only because I want ncdevmem to end
up as a TEST_GEN_FILES dependency (drivers/net/hw is the directory
that the vendors will eventually run against their HW so this is
where the HW-dependent tests are gonna stay for now).

Ah, OK. Makes sense then.

Reviewed-by: Mina Almasry <redacted>

Thanks!

-- 
Thanks,
Mina