Re: [PATCH net-next 01/10] lib: packing: refuse operating on bit indices which exceed size of buffer

From
Vladimir Oltean <vladimir.oltean@nxp.com>
Date
2024-10-02 13:44:14
Reply to
Jacob Keller, 2024-09-30
On Mon, Sep 30, 2024 at 04:19:34PM -0700, Jacob Keller wrote:
From: Vladimir Oltean <vladimir.oltean@nxp.com>

While reworking the implementation, it became apparent that this check
does not exist.

There is no functional issue yet, because at call sites, "startbit" and
"endbit" are always hardcoded to correct values, and never come from the
user.

Even with the upcoming support of arbitrary buffer lengths, the
"startbit >= 8 * pbuflen" check will remain correct. This is because
we intend to always interpret the packed buffer in a way that avoids
discontinuities in the available bit indices.

Fixes: 554aae35007e ("lib: Add support for generic packing operations")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
---
I thought that Fixes: tags are not in order for patches which are not
intended to be backported, and that is also clear from the commit message?
Thread (13 messages) 13 messages, 2 authors, last reply 2024-10-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help