Re: [PATCH net-next v4 5/8] net: mdio: mux-mmioreg: Simplified with dev_err_probe()
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2024-09-02 15:31:56
Also in:
linux-arm-kernel, linux-sunxi
On 8/29/2024 8:13 PM, Jinjie Ruan wrote:
quoted hunk ↗ jump to hunk
Use the dev_err_probe() helper to simplify code. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Jinjie Ruan <redacted> --- v4: - Remove the extra parentheses. v3: - Add Reviewed-by. v2: - Split into 2 patches. --- drivers/net/mdio/mdio-mux-mmioreg.c | 48 ++++++++++++----------------- 1 file changed, 20 insertions(+), 28 deletions(-)diff --git a/drivers/net/mdio/mdio-mux-mmioreg.c b/drivers/net/mdio/mdio-mux-mmioreg.c index 4d87e61fec7b..b70e6d1ad429 100644 --- a/drivers/net/mdio/mdio-mux-mmioreg.c +++ b/drivers/net/mdio/mdio-mux-mmioreg.c@@ -109,30 +109,25 @@ static int mdio_mux_mmioreg_probe(struct platform_device *pdev) return -ENOMEM; ret = of_address_to_resource(np, 0, &res); - if (ret) { - dev_err(&pdev->dev, "could not obtain memory map for node %pOF\n", - np); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "could not obtain memory map for node %pOF\n", np);
Besides that one, which I don't think is even a candidate for resource deferral in the first place given the OF platform implementation, it does not seem to help that much to switch to dev_err_probe() other than just combining the error message and return code in a single statement. So it's fewer lines of codes, but it is not exactly what dev_err_probe() was originally intended for IMHO. Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> -- Florian