Andy Shevchenko wrote:

On Sat, Aug 31, 2024 at 01:07:41PM -0700, Jakub Kicinski wrote:

quoted

On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote:

quoted

Use str_disabled_enabled() helper instead of open
coding the same.

...

quoted

quoted

 		netif_info(tun, drv, tun->dev, "ignored: set checksum %s\n",
-			   arg ? "disabled" : "enabled");
+			   str_disabled_enabled(arg));

You don't explain the 'why'. How is this an improvement?
nack on this and 2 similar networking changes you sent

Side opinion: This makes the messages more unified and not prone to typos
and/or grammatical mistakes. Unification allows to shrink binary due to
linker efforts on string literals deduplication.

This adds a layer of indirection.

The original code is immediately obvious. When I see the new code I
have to take a detour through cscope to figure out what it does.

To me, in this case, the benefit is too marginal to justify that.