Re: [RFC net-next 1/1] idpf: Don't hard code napi_struct size
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Date: 2024-09-30 13:11:11
Also in:
intel-wired-lan, lkml
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Date: 2024-09-30 13:11:11
Also in:
intel-wired-lan, lkml
On 9/30/24 14:38, Alexander Lobakin wrote:
From: Alexander Lobakin <aleksander.lobakin@intel.com> Date: Mon, 30 Sep 2024 14:33:45 +0200quoted
From: Joe Damato <redacted> Date: Wed, 25 Sep 2024 18:00:17 +0000
struct napi_struct doesn't have any such fields and doesn't depend on the kernel configuration, that's why it's hardcoded. Please don't change that, just adjust the hardcoded values when needed.
This is the crucial point, and I agree with Olek. If you will find it more readable/future proof, feel free to add comments like /* napi_struct */ near their "400" part in the hardcode. Side note: you could just run this as a part of your netdev series, given you will properly CC.