Thread (2 messages) 2 messages, 2 authors, 2024-09-22

Re: [PATCH] qlcnic: Use common error handling code in four functions

From: Simon Horman <horms@kernel.org>
Date: 2024-09-22 16:56:43
Also in: kernel-janitors, lkml

On Thu, Sep 19, 2024 at 09:50:13PM +0200, Markus Elfring wrote:
From: Markus Elfring <redacted>
Date: Thu, 19 Sep 2024 21:30:45 +0200

Add jump targets so that a bit of exception handling can be better reused
at the end of four function implementations.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>
Hi Markus,

This is an old driver, that doesn't appear to have been under active
development for quite some time. Unless there is a way to exercise these
changes I don't think that clean-ups of this nature are worth the risk of
regressions they might introduce.

If we can see bugs in error paths, let's fix them.
Else, let's leave them be.

-- 
pw-bot: rejected
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help