Thread (3 messages) 3 messages, 3 authors, 2024-09-15

Re: [PATCH net-next] net: ethernet: fs_enet: Make the per clock optional

From: Christophe JAILLET <hidden>
Date: 2024-09-14 09:02:05
Also in: linux-arm-kernel, linuxppc-dev, lkml

Le 14/09/2024 à 10:18, Maxime Chevallier a écrit :
quoted hunk ↗ jump to hunk
Some platforms that use fs_enet don't have the PER register clock. This
optional dependency on the clock was incorrectly made mandatory when
switching to devm_ accessors.

Reported-by: Christophe JAILLET <redacted>
Closes: https://lore.kernel.org/netdev/4e4defa9-ef2f-4ff1-95ca-6627c24db20c@wanadoo.fr/ (local)
Fixes: c614acf6e8e1 ("net: ethernet: fs_enet: simplify clock handling with devm accessors")
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
This patch fixes a commit in net-next.

  drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
index d300b01859a1..3425c4a6abcb 100644
--- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
+++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
@@ -895,7 +895,7 @@ static int fs_enet_probe(struct platform_device *ofdev)
  	 * but require enable to succeed when a clock was specified/found,
  	 * keep a reference to the clock upon successful acquisition
  	 */
-	clk = devm_clk_get_enabled(&ofdev->dev, "per");
+	clk = devm_clk_get_optional_enabled(&ofdev->dev, "per");
  	if (IS_ERR(clk))
  		goto out_free_fpi;
  
Reviewed-by: Christophe JAILLET <redacted>

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help