Re: [PATCH net-next v3 10/10] net: netconsole: fix wrong warning
From: Simon Horman <horms@kernel.org>
Date: 2024-09-10 14:50:11
Also in:
lkml
On Tue, Sep 10, 2024 at 03:04:05AM -0700, Breno Leitao wrote:
A warning is triggered when there is insufficient space in the buffer
for userdata. However, this is not an issue since userdata will be sent
in the next iteration.
Current warning message:
------------[ cut here ]------------
WARNING: CPU: 13 PID: 3013042 at drivers/net/netconsole.c:1122 write_ext_msg+0x3b6/0x3d0
? write_ext_msg+0x3b6/0x3d0
console_flush_all+0x1e9/0x330
The code incorrectly issues a warning when this_chunk is zero, which is
a valid scenario. The warning should only be triggered when this_chunk
is negative.
Signed-off-by: Breno Leitao <leitao@debian.org>
Fixes: 1ec9daf95093 ("net: netconsole: append userdata to fragmented netconsole messages")Reviewed-by: Simon Horman <horms@kernel.org>