Thread (13 messages) 13 messages, 2 authors, 2024-09-07

Re: [PATCH V7 net-next 01/11] net: hibmcge: Add pci table supported in this module

From: Jakub Kicinski <kuba@kernel.org>
Date: 2024-09-07 01:45:22
Also in: lkml

On Thu, 5 Sep 2024 22:31:10 +0800 Jijie Shao wrote:
+	netdev->tstats = devm_netdev_alloc_pcpu_stats(&pdev->dev,
+						      struct pcpu_sw_netstats);
+	if (!netdev->tstats)
+		return -ENOMEM;
Please set 

	dev->pcpu_stat_type = NETDEV_PCPU_STAT_TSTATS;

will allocate and free the stats for you.
This will also let other parts of the stack use the stats
since the type will be known (netdev->tstats is part of 
a union).
-- 
pw-bot: cr
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help