Re: [PATCH net-next v17 05/14] xtensa: remove the get_order() implementation
From: Alexander Duyck <hidden>
Date: 2024-09-04 15:49:03
Also in:
lkml
From: Alexander Duyck <hidden>
Date: 2024-09-04 15:49:03
Also in:
lkml
On Mon, Sep 2, 2024 at 5:09 AM Yunsheng Lin [off-list ref] wrote:
As the get_order() implemented by xtensa supporting 'nsau' instruction seems be the same as the generic implementation in include/asm-generic/getorder.h when size is not a constant value as the generic implementation calling the fls*() is also utilizing the 'nsau' instruction for xtensa. So remove the get_order() implemented by xtensa, as using the generic implementation may enable the compiler to do the computing when size is a constant value instead of runtime computing and enable the using of get_order() in BUILD_BUG_ON() macro in next patch. CC: Alexander Duyck <redacted> Signed-off-by: Yunsheng Lin <redacted> Acked-by: Max Filippov <jcmvbkbc@gmail.com> --- arch/xtensa/include/asm/page.h | 18 ------------------ 1 file changed, 18 deletions(-)
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>