On Tue, 3 Sep 2024 20:13:58 +0800 Jijie Shao wrote:

quoted

quoted

+{
+    struct hbg_priv *priv = netdev_priv(netdev);
+    struct phy_device *phydev = priv->mac.phydev;  

Minor nit: please respect the reverse x-mas tree order  

Here, I need to get the *priv first, so I'm not following the reverse x-mas tree order here.
I respect the reverse x-mas tree order everywhere else.

In this case you should move the init into the body of the function.