Re: [PATCH net-next 06/13] selftests: ncdevmem: Remove client_ip
From: Mina Almasry <hidden>
Date: 2024-09-12 20:35:50
On Thu, Sep 12, 2024 at 10:13 AM Stanislav Fomichev [off-list ref] wrote:
quoted hunk ↗ jump to hunk
It's used only in ntuple filter, but having dst address/port should be enough. Cc: Mina Almasry <redacted> Signed-off-by: Stanislav Fomichev <sdf@fomichev.me> --- tools/testing/selftests/net/ncdevmem.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)diff --git a/tools/testing/selftests/net/ncdevmem.c b/tools/testing/selftests/net/ncdevmem.c index c0da2b2e077f..77f6cb166ada 100644 --- a/tools/testing/selftests/net/ncdevmem.c +++ b/tools/testing/selftests/net/ncdevmem.c@@ -62,7 +62,6 @@ */ static char *server_ip = "192.168.1.4"; -static char *client_ip = "192.168.1.2"; static char *port = "5201"; static int start_queue = 8; static int num_queues = 8;@@ -228,8 +227,8 @@ static int configure_channels(unsigned int rx, unsigned int tx) static int configure_flow_steering(void) { - return run_command("sudo ethtool -N %s flow-type tcp4 src-ip %s dst-ip %s src-port %s dst-port %s queue %d >&2", - ifname, client_ip, server_ip, port, port, start_queue); + return run_command("sudo ethtool -N %s flow-type tcp4 dst-ip %s dst-port %s queue %d >&2", + ifname, server_ip, port, start_queue); }
Oh, sorry. I need 5-tuple rules here. Unfortunately GVE doesn't (yet) support 3 tuple rules that you're converting to here, AFAIR. Other drivers may also have a similar limitation. If you would like to add support for 3-tuples rules because your driver needs it, that's more than fine, but I would ask that this be configurable via a flag, or auto-detected by ncdevmem.