Re: [PATCH net-next 1/3] net: ethernet: ti: am65-cpsw: Address __percpu Sparse warnings
From: Jakub Kicinski <kuba@kernel.org>
Date: 2024-09-12 00:06:44
Also in:
linux-omap, llvm
On Tue, 10 Sep 2024 08:17:56 +0100 Simon Horman wrote:
An alternate, approach would be to create a variant of devm_add_action_or_reset() which expects __percpu data. This would avoid discarding the __percpu annotation, and any value it may have between the casts added by this patch. However, doing so appears to require a significant amount of plumbing. And, as far as I can see, the code updated by this patch would be the only user of it. So this patch takes a simpler approach.
Sorry if this was already discussed, but struct am65_cpsw_ndev_stats appears to be identical to struct pcpu_sw_netstats but for ordering. Can we let the core allocate the stats by setting netdev->pcpu_stat_type = NETDEV_PCPU_STAT_TSTATS?