Re: [PATCH net-next v3 0/4] Add option to provide OPT_ID value via cmsg

On 04/09/2024 22:04, Willem de Bruijn wrote:

quoted

quoted

Vadim Fedorenko (4):
    net_tstamp: add SCM_TS_OPT_ID to provide OPT_ID in control message
    net_tstamp: add SCM_TS_OPT_ID for TCP sockets
    net_tstamp: add SCM_TS_OPT_ID for RAW sockets
    selftests: txtimestamp: add SCM_TS_OPT_ID test

Oh, sorry for the mess, patches:

[PATCH v3 2/3] selftests: txtimestamp: add SCM_TS_OPT_ID test
[PATCH v3 3/3] net_tstamp: add SCM_TS_OPT_ID for TCP sockets

should be ignored.

If it too messy I can resend the series.

The series looks good to me. The four patches listed in the cover
letter summary.

Overall looks great.

Perhaps the test can now also test TCP and RAW with a fixed OPT_ID.

Sure, I'll add these tests. As well as changes to address comments for 
1/4 patch.

Thanks,
Vadim