Re: [PATCH net-next 2/8] Bluetooth: use min() to simplify the code

From
Simon Horman <horms@kernel.org>
Date
2024-08-24 18:15:19
Also in
ceph-devel, linux-bluetooth, linux-nfs
Reply to
Li Zetao, 2024-08-22
On Thu, Aug 22, 2024 at 09:39:02PM +0800, Li Zetao wrote:
When copying data from skb, it needs to determine the copy length.
It is easier to understand using min() here.

Signed-off-by: Li Zetao <redacted>
However, I don't believe Bluetooth changes usually don't go through next-next.
So I think this either needs to be reposted or get an ack from
the maintainer (already CCed).

Luiz, perhaps you can offer some guidance here?
quoted hunk ↗ jump to hunk
---
 net/bluetooth/hidp/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index 707f229f896a..7bf24f2993ba 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -294,7 +294,7 @@ static int hidp_get_raw_report(struct hid_device *hid,
 
 	skb = session->report_return;
 	if (skb) {
-		len = skb->len < count ? skb->len : count;
+		len = min(skb->len, count);
I am slightly dubious about this check, given the different types involved.
Is using min_t appropriate (I don't know)?
 		memcpy(data, skb->data, len);
 
 		kfree_skb(skb);
-- 
2.34.1
Thread (25 messages) 25 messages, 9 authors, last reply 2024-09-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help