Re: [PATCH net-next v3 08/13] net: mdio: mux-mmioreg: Simplified with dev_err_probe()
flat view
From: Andrew Lunn <andrew@lunn.ch>
Date: 2024-08-29 12:56:24
Also in:
linux-arm-kernel, linux-sunxi
quoted hunk ↗ jump to hunk
s->iosize = resource_size(&res); if (s->iosize != sizeof(uint8_t) && s->iosize != sizeof(uint16_t) && s->iosize != sizeof(uint32_t)) { - dev_err(&pdev->dev, "only 8/16/32-bit registers are supported\n"); - return -EINVAL; + return dev_err_probe(&pdev->dev, -EINVAL, + "only 8/16/32-bit registers are supported\n");
Please think about this change. Why is it wrong?
Andrew