Re: [Patch net-next] tcp_bpf: remove an unused parameter for bpf_tcp_ingress()
From: Martin KaFai Lau <martin.lau@linux.dev>
Date: 2024-08-27 21:50:09
Also in:
bpf
On 8/23/24 3:48 PM, Yaxin Chen wrote:
quoted hunk ↗ jump to hunk
Parameter flags is not used in bpf_tcp_ingress(). Reviewed-by: Cong Wang <redacted> Cc: John Fastabend <john.fastabend@gmail.com> Cc: Jakub Sitnicki <jakub@cloudflare.com> Signed-off-by: Yaxin Chen <redacted> --- net/ipv4/tcp_bpf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/net/ipv4/tcp_bpf.c b/net/ipv4/tcp_bpf.c index 53b0d62fd2c2..57a1614c55f9 100644 --- a/net/ipv4/tcp_bpf.c +++ b/net/ipv4/tcp_bpf.c@@ -30,7 +30,7 @@ void tcp_eat_skb(struct sock *sk, struct sk_buff *skb) } static int bpf_tcp_ingress(struct sock *sk, struct sk_psock *psock, - struct sk_msg *msg, u32 apply_bytes, int flags) + struct sk_msg *msg, u32 apply_bytes) { bool apply = apply_bytes; struct scatterlist *sge;@@ -167,7 +167,7 @@ int tcp_bpf_sendmsg_redir(struct sock *sk, bool ingress, if (unlikely(!psock)) return -EPIPE; - ret = ingress ? bpf_tcp_ingress(sk, psock, msg, bytes, flags) : + ret = ingress ? bpf_tcp_ingress(sk, psock, msg, bytes) :
lgtm also. John and Jakub Sitnicki, please help to take a look and Ack if this looks good to you also.
tcp_bpf_push_locked(sk, msg, bytes, flags, false); sk_psock_put(sk, psock); return ret;