Re: [PATCH v1] net: alacritech: Switch to use dev_err_probe()
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2024-08-30 16:54:24
Also in:
lkml
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2024-08-30 16:54:24
Also in:
lkml
On 28/08/2024 14:26, Yang Ruibin wrote:
use dev_err_probe() instead of dev_err() to simplify the error path and standardize the format of the error code. Signed-off-by: Yang Ruibin <redacted> --- drivers/net/ethernet/alacritech/slicoss.c | 34 ++++++++++------------- 1 file changed, 14 insertions(+), 20 deletions(-)diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c index 78231c852..65919ace0 100644 --- a/drivers/net/ethernet/alacritech/slicoss.c +++ b/drivers/net/ethernet/alacritech/slicoss.c@@ -1051,11 +1051,9 @@ static int slic_load_rcvseq_firmware(struct slic_device *sdev) file = (sdev->model == SLIC_MODEL_OASIS) ? SLIC_RCV_FIRMWARE_OASIS : SLIC_RCV_FIRMWARE_MOJAVE; err = request_firmware(&fw, file, &sdev->pdev->dev); - if (err) { - dev_err(&sdev->pdev->dev, + if (err) + return dev_err_probe(&sdev->pdev->dev, err, "failed to load receive sequencer firmware %s\n", file);
NAK. Vivo does not understand how deferred probe works or introduces intentionally buggy code. This must be reverted. Best regards, Krzysztof