Re: [PATCH nf-next v3 1/2] netfilter: Make IP_NF_IPTABLES_LEGACY selectable

On Thu, Aug 29, 2024 at 07:53:03AM -0700, Jakub Kicinski wrote:

On Thu, 29 Aug 2024 03:08:01 -0700 Breno Leitao wrote:

quoted

quoted

There are various configs in the tree. Grep for the configs you convert
from select to depends on, they will all need updating.  

I am looking at all files that depend on these Kconfig options, and
there are a lot of tests.

Thinking more about the problem, it doesn't seem to be a good idea to
change dependency from all NF modules to NF_IPTABLES_LEGACY. In other
words, the `s/selects/depends on/` is the part that is causing all this
hassle, and it seems unnecessary.

That said, I would suggest we do not change the dependency, and keep the
"select NF_IPTABLES_LEGACY", and keep NF_IPTABLES_LEGACY user selectable.

Good idea, sounds much simpler!

Thanks, I will submit the patch soon.
--breno