Re: [PATCH v1 net-next] net: openvswitch: Use ERR_CAST() to return
From: Eelco Chaudron <echaudro@redhat.com>
Date: 2024-08-29 10:17:48
Also in:
lkml
On 29 Aug 2024, at 11:55, Yan Zhen wrote:
quoted hunk ↗ jump to hunk
Using ERR_CAST() is more reasonable and safer, When it is necessary to convert the type of an error pointer and return it. Signed-off-by: Yan Zhen <redacted> --- net/openvswitch/flow_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c index c92bdc4dfe19..729ef582a3a8 100644 --- a/net/openvswitch/flow_netlink.c +++ b/net/openvswitch/flow_netlink.c@@ -2491,7 +2491,7 @@ static struct nlattr *reserve_sfa_size(struct sw_flow_actions **sfa, acts = nla_alloc_flow_actions(new_acts_size); if (IS_ERR(acts)) - return (void *)acts; + return ERR_CAST(acts);
Change looks good to me. Acked-by: Eelco Chaudron <echaudro@redhat.com>
memcpy(acts->actions, (*sfa)->actions, (*sfa)->actions_len); acts->actions_len = (*sfa)->actions_len; -- 2.34.1