Thread (11 messages) 11 messages, 3 authors, 2024-09-04

Re: [PATCH net-next V4 4/5] net: lan743x: Migrate phylib to phylink

From: Maxime Chevallier <maxime.chevallier@bootlin.com>
Date: 2024-08-29 07:49:16
Also in: lkml

Hello Raju,

On Thu, 29 Aug 2024 11:21:31 +0530
Raju Lakkaraju [off-list ref] wrote:
Migrate phy support from phylib to phylink.

Signed-off-by: Raju Lakkaraju <redacted>
[...]
+static void lan743x_phylink_disconnect(struct lan743x_adapter *adapter)
+{
+	struct net_device *netdev = adapter->netdev;
+	struct phy_device *phydev = netdev->phydev;
+
+	phylink_stop(adapter->phylink);
+	phylink_disconnect_phy(adapter->phylink);
+
+	if (phydev)
+		if (phy_is_pseudo_fixed_link(phydev))
+			fixed_phy_unregister(phydev);
You shouldn't manually deal with the fixed_phy when using phylink, it
handles fixed links already for you, without a PHY.

Thanks,

Maxime
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help