Re: [PATCH v12 3/5] dt-bindings: net: wireless: brcm4329-fmac: change properties enum structure

On 2024/8/28 16:50, Arend van Spriel wrote:

On 8/28/2024 9:40 AM, Jacobe Zang wrote:

quoted

Add "brcm,bcm4329-fmac" as fallback compatible for wireless devices that
used PCI ID based compatible. So that can pass the compatible check in
driver.

Hi Jacobe,

Using the driver implementation as an argument for adding the fallback 

Yes, so I changed the argument in v13 which seemed doesn't matter now ;-)

compatible to the bindings does sound wrong. The most importants rule 
about the bindings is that it is independent of kernel and/or driver 
implementation.

Now this actually overlaps my patch series from couple of weeks ago 
which also covered some other existing DTS files for Apple platforms. So 
my proposal here is to drop this patch for now. I will give it another 

Okay ;-)

shot in v2 of my series after yours is (finally) applied. We can always 
hope ;-) That does also mean the compatible check in the driver should 
not be moved in brcmf_of_probe(). Also the Khadas Edge2 DTS file should 

I see. Thanks for your information.

not use the fallback compatible yet. I can include it in my series later.

Regards,
Arend

quoted

Signed-off-by: Jacobe Zang <redacted>
---
  .../bindings/net/wireless/brcm,bcm4329-fmac.yaml     | 20 ++++++++++ 
+---------
  1 file changed, 11 insertions(+), 9 deletions(-)

-- 
Best Regards
Jacobe