Thread (13 messages) 13 messages, 2 authors, 2024-08-28

Re: [PATCH v4 3/7] block: mtip32xx: Replace deprecated PCI functions

From: Jens Axboe <axboe@kernel.dk>
Date: 2024-08-27 19:05:47
Also in: linux-block, linux-fpga, linux-gpio, linux-pci, lkml, virtualization

On 8/27/24 12:56 PM, Philipp Stanner wrote:
pcim_iomap_regions() and pcim_iomap_table() have been deprecated by the
PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
pcim_iomap_table(), pcim_iomap_regions_request_all()").

In mtip32xx, these functions can easily be replaced by their respective
successors, pcim_request_region() and pcim_iomap(). Moreover, the
driver's calls to pcim_iounmap_regions() in probe()'s error path and in
remove() are not necessary. Cleanup can be performed by PCI devres
automatically.

Replace pcim_iomap_regions() and pcim_iomap_table().

Remove the calls to pcim_iounmap_regions().
Looks fine to me - since it depends on other trees, feel free to take it
through those:

Reviewed-by: Jens Axboe <axboe@kernel.dk>

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help