Thread (43 messages) 43 messages, 7 authors, 2024-09-19

Re: [PATCH V4 11/12] bnxt_en: Add TPH support in BNXT driver

From: Jakub Kicinski <kuba@kernel.org>
Date: 2024-08-26 20:22:15
Also in: linux-doc, linux-pci, lkml

On Thu, 22 Aug 2024 15:41:19 -0500 Wei Huang wrote:
+		rtnl_lock();
+		bnxt_close_nic(irq->bp, false, false);
+		bnxt_open_nic(irq->bp, false, false);
+		rtnl_unlock();
This code means that under memory pressure changing CPU affinity
can take the machine offline. The entire machine, even if container
orchestration is trying to just move a few IRQs in place for a new
container.

We can't let you do this, it will set a bad precedent. I can't think
of any modern driver with reconfiguration safety as bad as bnxt.
Technical debt coming due.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help