Re: [PATCH net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG
From: Jiri Pirko <jiri@resnulli.us>
Date: 2024-08-26 11:17:12
Also in:
intel-wired-lan, lkml
Mon, Aug 26, 2024 at 12:17:10PM CEST, tbogendoerfer@suse.de wrote:
On Mon, 26 Aug 2024 11:41:19 +0200 Jiri Pirko [off-list ref] wrote:quoted
Mon, Aug 26, 2024 at 10:58:30AM CEST, tbogendoerfer@suse.de wrote:quoted
For PFs, which don't support SRIOV_LAG, there is no pf->lag struct allocated. So before accessing pf->lag a NULL pointer check is needed. Signed-off-by: Thomas Bogendoerfer <redacted>You need to add a "fixes" tag blaming the commit that introduced the bug.of course... Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for SRIOV on bonded interface") Should I resend the patch ?
Yes.
Thomas. -- SUSE Software Solutions Germany GmbH HRB 36809 (AG Nürnberg) Geschäftsführer: Ivo Totev, Andrew McDonald, Werner Knoblich