Re: [PATCH next 1/2] dt-bindings: net: bluetooth: nxp: support multiple init baudrates
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2024-08-24 06:30:32
Also in:
linux-bluetooth, linux-devicetree, lkml
On Fri, Aug 23, 2024 at 02:42:38PM +0200, Catalin Popescu wrote:
quoted hunk ↗ jump to hunk
Make "fw-init-baudrate" a list of baudrates in order to support chips using different baudrates assuming that we could not detect the supported baudrate otherwise. Signed-off-by: Catalin Popescu <redacted> --- .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml index 37a65badb448..42e3713927de 100644 --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml@@ -25,11 +25,12 @@ properties: fw-init-baudrate: $ref: /schemas/types.yaml#/definitions/uint32 + maxItems: 8 default: 115200 description: - Chip baudrate after FW is downloaded and initialized. - This property depends on the module vendor's - configuration. + List of chip baudrates after FW is downloaded and initialized. + The driver goes through the list until it founds a working baudrate. + This property depends on the module vendor's configuration.
You need to test your patch... and update the example and explain why changing from 1 to 8 items (so ABI break) is okay or needed. But even without updating the example, you would see errors when testing DTS, so this was never tested. :/ Best regards, Krzysztof