Thread (18 messages) 18 messages, 2 authors, 2024-08-23

Re: [PATCH V3 net-next 03/11] net: hibmcge: Add mdio and hardware configuration supported in this module

From: Andrew Lunn <andrew@lunn.ch>
Date: 2024-08-22 16:13:12
Also in: lkml

+void hbg_phy_start(struct hbg_priv *priv)
+{
+	if (!priv->mac.phydev)
+		return;
+
+	phy_start(priv->mac.phydev);
+}
+
+void hbg_phy_stop(struct hbg_priv *priv)
+{
+	if (!priv->mac.phydev)
+		return;
+
+	phy_stop(priv->mac.phydev);
Can this condition priv->mac.phydev not be true? The mdio bus setup
and connecting to the PHY seems to be unconditional. If it fails, the
driver fails to probe.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help