Re: [PATCH v3 6/9] ethernet: stmicro: Simplify PCI devres usage
From: Andy Shevchenko <andy@kernel.org>
Date: 2024-08-22 14:47:05
Also in:
linux-arm-kernel, linux-block, linux-doc, linux-fpga, linux-gpio, linux-pci, lkml, virtualization
On Thu, Aug 22, 2024 at 03:47:38PM +0200, Philipp Stanner wrote:
stmicro uses PCI devres in the wrong way. Resources requested
through pcim_* functions don't need to be cleaned up manually in the
remove() callback or in the error unwind path of a probe() function.
Moreover, there is an unnecessary loop which only requests and ioremaps
BAR 0, but iterates over all BARs nevertheless.
Furthermore, pcim_iomap_regions() and pcim_iomap_table() have been
deprecated by the PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
pcim_iomap_table(), pcim_iomap_regions_request_all()").
Replace these functions with pcim_iomap_region().
Remove the unnecessary manual pcim_* cleanup calls.
Remove the unnecessary loop over all BARs....
- /* Get the base address of device */ + /* Request the base address BAR of device */
It's a tautology, "BAR" == Base Address ... -- With Best Regards, Andy Shevchenko