On Wed, Aug 21, 2024 at 10:19 AM Philipp Stanner [off-list ref] wrote:

pcim_iomap_regions() and pcim_iomap_table() have been deprecated by the
PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
pcim_iomap_table(), pcim_iomap_regions_request_all()").

In mtip32xx, these functions can easily be replaced by their respective
successors, pcim_request_region() and pcim_iomap(). Moreover, the
driver's calls to pcim_iounmap_regions() in probe()'s error path and in
remove() are not necessary. Cleanup can be performed by PCI devres
automatically.

Replace pcim_iomap_regions() and pcim_iomap_table().

Remove the calls to pcim_iounmap_regions().

...

 setmask_err:
-       pcim_iounmap_regions(pdev, 1 << MTIP_ABAR);
-
 iomap_err:

Now one of the labels is redundant.

        kfree(dd);
        pci_set_drvdata(pdev, NULL);

-- 
With Best Regards,
Andy Shevchenko