Thread (36 messages) 36 messages, 5 authors, 2024-08-20

Re: [PATCH 6/9] ethernet: cavium: Replace deprecated PCI functions

From: Andy Shevchenko <andy@kernel.org>
Date: 2024-08-19 18:23:18
Also in: linux-arm-kernel, linux-block, linux-doc, linux-fpga, linux-gpio, linux-pci, lkml, virtualization

On Mon, Aug 19, 2024 at 06:51:46PM +0200, Philipp Stanner wrote:
pcim_iomap_regions() and pcim_iomap_table() have been deprecated by
the PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
pcim_iomap_table(), pcim_iomap_regions_request_all()").

Replace these functions with the function pcim_iomap_region().
...

cavium_ptp_probe()
-	pcim_iounmap_regions(pdev, 1 << PCI_PTP_BAR_NO);
+	pcim_iounmap_region(pdev, PCI_PTP_BAR_NO);
 
 error_free:
 	devm_kfree(dev, clock);
Both are questionable. Why do we need either of them?

-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help