Re: [PATCH net-next v19 03/13] netdev: support binding dma-buf to netdevice
From: Jakub Kicinski <kuba@kernel.org>
Date: 2024-08-16 00:50:28
Also in:
bpf, dri-devel, linux-alpha, linux-arch, linux-doc, linux-kselftest, linux-media, linux-mips, linux-trace-kernel, lkml, sparclinux
On Tue, 13 Aug 2024 21:13:05 +0000 Mina Almasry wrote:
+ if (NL_REQ_ATTR_CHECK(info->extack, attr, tb,
+ NETDEV_A_QUEUE_ID)) {
+ err = -EINVAL;
+ goto err_unlock;
+ }
+
+ if (NL_REQ_ATTR_CHECK(info->extack, attr, tb,
+ NETDEV_A_QUEUE_TYPE)) {
+ err = -EINVAL;
+ goto err_unlock;
+ }
+
+ if (nla_get_u32(tb[NETDEV_A_QUEUE_TYPE]) !=
+ NETDEV_QUEUE_TYPE_RX) {
+ err = -EINVAL;
+ goto err_unlock;
+ }nit: you can || these three into as single if statement