Re: [PATCH net-next v19 03/13] netdev: support binding dma-buf to netdevice

From
Jakub Kicinski <kuba@kernel.org>
Date
2024-08-16 00:50:28
Also in
bpf, dri-devel, linux-alpha, linux-arch, linux-doc, linux-kselftest, linux-media, linux-mips, linux-trace-kernel, lkml, sparclinux
Reply to
Mina Almasry, 2024-08-13
On Tue, 13 Aug 2024 21:13:05 +0000 Mina Almasry wrote:
quoted hunk ↗ jump to hunk
+		if (NL_REQ_ATTR_CHECK(info->extack, attr, tb,
+				      NETDEV_A_QUEUE_ID)) {
+			err = -EINVAL;
+			goto err_unlock;
+		}
+
+		if (NL_REQ_ATTR_CHECK(info->extack, attr, tb,
+				      NETDEV_A_QUEUE_TYPE)) {
+			err = -EINVAL;
+			goto err_unlock;
+		}
+
+		if (nla_get_u32(tb[NETDEV_A_QUEUE_TYPE]) !=
+		    NETDEV_QUEUE_TYPE_RX) {
+			err = -EINVAL;
+			goto err_unlock;
+		}
nit: you can || these three into as single if statement
Thread (14 messages) 14 messages, 3 authors, last reply 2024-08-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help