Thread (5 messages) 5 messages, 3 authors, 2024-08-20

Re: [PATCH v2] softirq: remove parameter from action callback

From: Jens Axboe <axboe@kernel.dk>
Date: 2024-08-15 17:35:41
Also in: linux-block, lkml, rcu

On 8/15/24 11:15 AM, Caleb Sander Mateos wrote:
When softirq actions are called, they are passed a pointer to the entry
in the softirq_vec table containing the action's function pointer. This
pointer isn't very useful, as the action callback already knows what
function it is. And since each callback handles a specific softirq, the
callback also knows which softirq number is running.

No softirq action callbacks actually use this parameter, so remove it
from the function pointer signature. This clarifies that softirq actions
are global routines and makes it slightly cheaper to call them.

v2: use full 72 characters in commit description lines, add Reviewed-by
No need to resend because of it, but the changelog bits go below the ---
line, not in the commit message. Whoever applies can just take care of
that.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help