Thread (11 messages) 11 messages, 2 authors, 2024-08-13

Re: [PATCH net-next v3 1/6] netdevice: convert private flags > BIT(31) to bitfields

From: Alexander Lobakin <aleksander.lobakin@intel.com>
Date: 2024-08-12 12:09:41
Also in: lkml

From: Jakub Kicinski <kuba@kernel.org>
Date: Fri, 9 Aug 2024 22:27:55 -0700
On Thu,  8 Aug 2024 17:27:52 +0200 Alexander Lobakin wrote:
quoted
+ *	@priv_flags_fast: both hotpath private flags as bits and as bitfield
+ *			booleans combined, only to assert cacheline placement
+ *	@priv_flags:	flags invisible to userspace defined as bits, see
+ *			enum netdev_priv_flags for the definitions
The kdoc scripts says:

include/linux/netdevice.h:2392: warning: Excess struct member 'priv_flags_fast' description in 'net_device'

I thought you sent a kernel-doc patch during previous cycle to fix this,
or was that for something else?
Oh crap.
The patch I sent expands struct_group_tagged() only.
If I do the same for the regular struct_group(), there'll clearly be a
ton of new warnings.
I think I'll just submit v4 with removing this line from the kdoc?

Thanks,
Olek

 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help