RE: [PATCH net-next V3 3/4] net: lan743x: Migrate phylib to phylink
From: <hidden>
Date: 2024-08-08 20:24:12
Also in:
lkml
-----Original Message----- From: Russell King <linux@armlinux.org.uk> Sent: Friday, August 2, 2024 4:37 AM To: Ronnie Kunin - C21729 <redacted> Cc: Raju Lakkaraju - I30499 <redacted>; netdev@vger.kernel.org; davem@davemloft.net; kuba@kernel.org; andrew@lunn.ch; horms@kernel.org; hkallweit1@gmail.com; richardcochran@gmail.com; rdunlap@infradead.org; Bryan Whitehead - C21958 [off-list ref]; edumazet@google.com; pabeni@redhat.com; linux- kernel@vger.kernel.org; UNGLinuxDriver [off-list ref] Subject: Re: [PATCH net-next V3 3/4] net: lan743x: Migrate phylib to phylink ...quoted
In the longer term, it would probably make sense for phylink to provide a mechanism where a MAC driver can tell phylink to switch to using a fixed-link with certain parameters.... I think it's time to implement the suggestion in the last paragraph rather than using fixed-phy.
We looked into an alternate way to migrate our lan743x driver from phylib to phylink continuing to support our existing hardware out in the field, without using the phylib's fixed-phy approach that you opposed to, but without modifying the phylib framework either. While investigating how to implement it we came across this which Raju borrowed ideas from: https://lore.kernel.org/linux-arm-kernel/YtGPO5SkMZfN8b%2Fs@shell.armlinux.org.uk/ (local) . He is in the process of testing/cleaning it up and expects to submit it early next week.