Thread (6 messages) 6 messages, 5 authors, 2024-08-07

RE: [PATCH net] net: mana: Fix doorbell out of order violation and avoid unnecessary doorbell rings

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: 2024-08-06 15:56:19
Also in: linux-hyperv, linux-rdma, lkml, stable

-----Original Message-----
From: longli@linuxonhyperv.com <redacted>
Sent: Monday, August 5, 2024 7:38 PM
To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
[off-list ref]; Wei Liu [off-list ref]; Dexuan Cui
[off-list ref]; David S. Miller [off-list ref]; Eric Dumazet
[off-list ref]; Jakub Kicinski [off-list ref]; Paolo Abeni
[off-list ref]; Shradha Gupta [off-list ref];
Simon Horman [off-list ref]; Konstantin Taranov
[off-list ref]; Souradeep Chakrabarti
[off-list ref]; Erick Archer
[off-list ref]; linux-hyperv@vger.kernel.org;
netdev@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
rdma@vger.kernel.org
Cc: Long Li <longli@microsoft.com>; stable@vger.kernel.org
Subject: [PATCH net] net: mana: Fix doorbell out of order violation and
avoid unnecessary doorbell rings

From: Long Li <longli@microsoft.com>

After napi_complete_done() is called, another NAPI may be running on
another CPU and ring the doorbell before the current CPU does. When
combined with unnecessary rings when there is no need to ARM the CQ, this
triggers error paths in the hardware.

Fix this by always ring the doorbell in sequence and avoid unnecessary
rings.

Cc: stable@vger.kernel.org
Fixes: e1b5683ff62e ("net: mana: Move NAPI from EQ to CQ")
Signed-off-by: Long Li <longli@microsoft.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>

Thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help