Thread (10 messages) read the whole thread 10 messages, 4 authors, 2024-08-05
STALE727d

[PATCH v2] net: ethernet: remove unnecessary parentheses

From: Moon Yeounsu <hidden>
Date: 2024-08-03 02:30:13
Also in: lkml
Subsystem: jme network driver, networking drivers, the rest · Maintainers: Guo-Fu Tseng, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

remove unnecessary parentheses surrounding `ip_hdrlen()`,
And keep it under 80 columns long to follow the kernel coding style.

Signed-off-by: Moon Yeounsu <redacted>
---
 drivers/net/ethernet/jme.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
index 83b185c995df..d8be0e4dcb07 100644
--- a/drivers/net/ethernet/jme.c
+++ b/drivers/net/ethernet/jme.c
@@ -947,12 +947,12 @@ jme_udpsum(struct sk_buff *skb)
 		return csum;
 	skb_set_network_header(skb, ETH_HLEN);
 
-	if ((ip_hdr(skb)->protocol != IPPROTO_UDP) ||
-	    (skb->len < (ETH_HLEN + (ip_hdrlen(skb)) + sizeof(struct udphdr)))) {
+	if (ip_hdr(skb)->protocol != IPPROTO_UDP ||
+	    skb->len < (ETH_HLEN + ip_hdrlen(skb) + sizeof(struct udphdr))) {
 		skb_reset_network_header(skb);
 		return csum;
 	}
-	skb_set_transport_header(skb, ETH_HLEN + (ip_hdrlen(skb)));
+	skb_set_transport_header(skb, ETH_HLEN + ip_hdrlen(skb));
 	csum = udp_hdr(skb)->check;
 	skb_reset_transport_header(skb);
 	skb_reset_network_header(skb);
-- 
2.45.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help