Thread (51 messages) 51 messages, 4 authors, 2025-07-29

Re: [RFC PATCH net-next v6 12/14] vsock/loopback: implement datagram support

From: Luigi Leonardi <hidden>
Date: 2024-08-01 12:18:23
Also in: bpf, kvm, linux-hyperv, lkml, virtualization

quoted hunk ↗ jump to hunk
+static bool vsock_loopback_dgram_allow(u32 cid, u32 port)
+{
+	return true;
+}
+
 static bool vsock_loopback_seqpacket_allow(u32 remote_cid);
 static bool vsock_loopback_msgzerocopy_allow(void)
 {
@@ -66,7 +71,7 @@ static struct virtio_transport loopback_transport = {
 		.cancel_pkt               = vsock_loopback_cancel_pkt,

 		.dgram_enqueue            = virtio_transport_dgram_enqueue,
-		.dgram_allow              = virtio_transport_dgram_allow,
+		.dgram_allow              = vsock_loopback_dgram_allow,

 		.stream_dequeue           = virtio_transport_stream_dequeue,
 		.stream_enqueue           = virtio_transport_stream_enqueue,
--
2.20.1
Code LGTM! Just because you have to send a new version I'd modify
the commit message to something like:
"Add 'vsock_loopback_dgram_allow' callback for datagram support."

Feel free to change it :)

Thank you,
Luigi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help