RE: [Intel-wired-lan] [PATCH iwl-next v3 5/6] ice: dump ethtool stats and skb by Tx hang devlink health reporter

From
Pucha, HimasekharX Reddy <hidden>
Date
2024-08-29 14:35:01
Also in
intel-wired-lan
Reply to
Przemek Kitszel, 2024-08-21
-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of Przemek Kitszel
Sent: Wednesday, August 21, 2024 7:07 PM
To: <redacted>; Jiri Pirko <jiri@resnulli.us>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>
Cc: lukas.bulwahn@gmail.com; willemb@google.com; Drewek, Wojciech <redacted>; dwaipayanray1@gmail.com; <redacted>; Polchlopek, Mateusz <redacted>; Bagnucki, Igor <redacted>; joe@perches.com; Eric Dumazet <redacted>; Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>; Simon Horman <horms@kernel.org>; Jakub Kicinski <kuba@kernel.org>; apw@canonical.com; NEX SW NCIS OSDT ITP Upstreaming <redacted>; akpm@linux-foundation.org; Paolo Abeni <pabeni@redhat.com>; David S. Miller <davem@davemloft.net>
Subject: [Intel-wired-lan] [PATCH iwl-next v3 5/6] ice: dump ethtool stats and skb by Tx hang devlink health reporter

Print the ethtool stats and skb diagnostic information as part of Tx hang devlink health dump.

Move the declarations of ethtool functions that devlink health uses out to a new file: ice_ethtool_common.h

To utilize our existing ethtool code in this context, convert it to non-static.

Reviewed-by: Igor Bagnucki <redacted>
Reviewed-by: Wojciech Drewek <redacted>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Mateusz Polchlopek <redacted>
Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_ethtool.h  |  2 +
 .../ethernet/intel/ice/ice_ethtool_common.h   | 19 ++++++++++
 .../intel/ice/devlink/devlink_health.c        | 37 +++++++++++++++++++
 drivers/net/ethernet/intel/ice/ice_ethtool.c  | 10 ++---
 4 files changed, 63 insertions(+), 5 deletions(-)  create mode 100644 drivers/net/ethernet/intel/ice/ice_ethtool_common.h
Tested-by: Pucha Himasekhar Reddy <redacted> (A Contingent worker at Intel)
Thread (13 messages) 13 messages, 3 authors, last reply 2024-08-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help