Thread (5 messages) flat view 5 messages, 2 authors, 2024-08-22

Re: [PATCH net 1/3] netfilter: nft_counter: Disable BH in nft_counter_offload_stats().

From: patchwork-bot+netdevbpf@kernel.org
Date: 2024-08-22 20:10:41
Also in: netfilter-devel

Hello:

This series was applied to netdev/net.git (main)
by Pablo Neira Ayuso [off-list ref]:

On Thu, 22 Aug 2024 12:18:40 +0200 you wrote:
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

The sequence counter nft_counter_seq is a per-CPU counter. There is no
lock associated with it. nft_counter_do_eval() is using the same counter
and disables BH which suggest that it can be invoked from a softirq.
This in turn means that nft_counter_offload_stats(), which disables only
preemption, can be interrupted by nft_counter_do_eval() leading to two
writer for one seqcount_t.
This can lead to loosing stats or reading statistics while they are
updated.

[...]
Here is the summary with links:
  - [net,1/3] netfilter: nft_counter: Disable BH in nft_counter_offload_stats().
    https://git.kernel.org/netdev/net/c/1eacdd71b343
  - [net,2/3] netfilter: nft_counter: Synchronize nft_counter_reset() against reader.
    https://git.kernel.org/netdev/net/c/a0b39e2dc701
  - [net,3/3] netfilter: flowtable: validate vlan header
    https://git.kernel.org/netdev/net/c/6ea14ccb60c8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help