Antony Antony [off-list ref] writes:

Hi Chris,

On Wed, Aug 07, 2024 at 05:13:14PM -0400, Christian Hopps wrote:

quoted

* Summary of Changes:

...

quoted

v8->v9 (8/7/2024)
  - factor common code from skbuff.c:__copy_skb_header into ___copy_skb_header
    and use in iptfs rather that copying any code.
  - change all BUG_ON to WARN_ON_ONCE
  - remove unwanted new NOSKB xfrm MIB error counter
  - remove unneeded copy or share choice function
  - ifdef CONFIG_IPV6 around IPv6 function

I noticed a build error with CONFIG_XFRM_IPTFS=m. This error also shows up
in in NetDev NIPA tester. However, it kernel builds with CONFIG_XFRM_IPTFS=y

Indeed. Added the missing EXPORT_SYMBOL_GPL(___copy_skb_header) now..

a@laya:~/git/linux (iptfs-patchset-v9-20240808)$ make
  CALL    scripts/checksyscalls.sh
  DESCEND objtool
  INSTALL libsubcmd_headers
  MODPOST Module.symvers
ERROR: modpost: "___copy_skb_header" [net/xfrm/xfrm_iptfs.ko] undefined!
make[2]: *** [scripts/Makefile.modpost:145: Module.symvers] Error 1
make[1]: *** [/home/a/git/linux/Makefile:1878: modpost] Error 2
make: *** [Makefile:224: __sub-make] Error 2

NIPA tester also noticed the build error.
https://netdev.bots.linux.dev/static/nipa/877576/13756764/build_clang/stderr
I wonder why the  kernel test robot hasn't caught this yet.

It just hasn't gotten there yet. :)

Also note a few minor issues with the patches, specifically for the patch
ipsec-next,v9,14/17
https://netdev.bots.linux.dev/static/nipa/877576/13756763/build_clang/stderr

I'll fix these, they are transient warnings based on how I split the patchset.

Thanks,
Chris.

-antony