Re: [PATCH net v4 1/3] net: Make USO depend on CSUM offload

From
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date
2024-08-08 19:28:07
Reply to
Jakub Sitnicki, 2024-08-08
Jakub Sitnicki wrote:
UDP segmentation offload inherently depends on checksum offload. It should
not be possible to disable checksum offload while leaving USO enabled.
Enforce this dependency in code.

There is a single tx-udp-segmentation feature flag to indicate support for
both IPv4/6, hence the devices wishing to support USO must offer checksum
offload for both IP versions.

Fixes: 10154dbded6d ("udp: Allow GSO transmit from devices with no checksum offload")
Suggested-by: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Thread (6 messages) 6 messages, 3 authors, last reply 2024-08-10
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help